From d250524208c140e9e68b3e0637a91b3b189155f7 Mon Sep 17 00:00:00 2001 From: real-zony Date: Sat, 19 Mar 2022 11:42:00 +0800 Subject: [PATCH] feat: QQ Music Downloader support dual language lyrics. --- .../Lyric/QQMusic/QQLyricDownloader.cs | 2 +- .../Infrastructure/Lyric/QQLyricDownloaderTests.cs | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/ZonyLrcTools.Cli/Infrastructure/Lyric/QQMusic/QQLyricDownloader.cs b/src/ZonyLrcTools.Cli/Infrastructure/Lyric/QQMusic/QQLyricDownloader.cs index e2a2365..1cac4a6 100644 --- a/src/ZonyLrcTools.Cli/Infrastructure/Lyric/QQMusic/QQLyricDownloader.cs +++ b/src/ZonyLrcTools.Cli/Infrastructure/Lyric/QQMusic/QQLyricDownloader.cs @@ -65,7 +65,7 @@ namespace ZonyLrcTools.Cli.Infrastructure.Lyric.QQMusic var sourceLyric = HttpUtility.HtmlDecode(HttpUtility.HtmlDecode(lyricJsonObj.SelectToken("$.lyric").Value())); var translateLyric = HttpUtility.HtmlDecode(HttpUtility.HtmlDecode(lyricJsonObj.SelectToken("$.trans").Value())); - return _lyricItemCollectionFactory.Build(sourceLyric); + return _lyricItemCollectionFactory.Build(sourceLyric, translateLyric); } protected virtual void ValidateSongSearchResponse(SongSearchResponse response, LyricDownloaderArgs args) diff --git a/tests/ZonyLrcTools.Tests/Infrastructure/Lyric/QQLyricDownloaderTests.cs b/tests/ZonyLrcTools.Tests/Infrastructure/Lyric/QQLyricDownloaderTests.cs index 303bbc2..dc89f1f 100644 --- a/tests/ZonyLrcTools.Tests/Infrastructure/Lyric/QQLyricDownloaderTests.cs +++ b/tests/ZonyLrcTools.Tests/Infrastructure/Lyric/QQLyricDownloaderTests.cs @@ -25,5 +25,17 @@ namespace ZonyLrcTools.Tests.Infrastructure.Lyric lyric.ShouldNotBeNull(); lyric.IsPruneMusic.ShouldBe(false); } + + // About the new feature mentioned in issue #87. + // Github Issue: https://github.com/real-zony/ZonyLrcToolsX/issues/87 + [Fact] + public async Task DownloadAsync_Issue85_Test() + { + var lyric = await _lyricDownloader.DownloadAsync("Looking at Me", "Sabrina Carpenter"); + + lyric.ShouldNotBeNull(); + lyric.IsPruneMusic.ShouldBeFalse(); + lyric.ToString().ShouldContain("你好像快要不能呼吸"); + } } } \ No newline at end of file