From 0712183a187acd03f6b27dbea82e7a53ce000453 Mon Sep 17 00:00:00 2001
From: Zack Pollard <zack@futo.org>
Date: Tue, 27 May 2025 16:38:16 +0100
Subject: [PATCH] fix: replace edit user button with view button for user
 details screen (#18683)

---
 i18n/en.json                            |  1 +
 web/src/routes/admin/users/+page.svelte | 26 +++++++++----------------
 2 files changed, 10 insertions(+), 17 deletions(-)

diff --git a/i18n/en.json b/i18n/en.json
index d826ebc42a..10d332f3bf 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -1943,6 +1943,7 @@
   "view_previous_asset": "View previous asset",
   "view_qr_code": "View QR code",
   "view_stack": "View Stack",
+  "view_user": "View User",
   "viewer_remove_from_stack": "Remove from Stack",
   "viewer_stack_use_as_main_asset": "Use as Main Asset",
   "viewer_unstack": "Un-Stack",
diff --git a/web/src/routes/admin/users/+page.svelte b/web/src/routes/admin/users/+page.svelte
index 36f1f9a5b8..87846b9542 100644
--- a/web/src/routes/admin/users/+page.svelte
+++ b/web/src/routes/admin/users/+page.svelte
@@ -10,7 +10,6 @@
   import { modalManager } from '$lib/managers/modal-manager.svelte';
   import UserCreateModal from '$lib/modals/UserCreateModal.svelte';
   import UserDeleteConfirmModal from '$lib/modals/UserDeleteConfirmModal.svelte';
-  import UserEditModal from '$lib/modals/UserEditModal.svelte';
   import UserRestoreConfirmModal from '$lib/modals/UserRestoreConfirmModal.svelte';
   import { locale } from '$lib/stores/preferences.store';
   import { serverConfig } from '$lib/stores/server-config.store';
@@ -18,8 +17,8 @@
   import { websocketEvents } from '$lib/stores/websocket';
   import { getByteUnitString } from '$lib/utils/byte-units';
   import { UserStatus, searchUsersAdmin, type UserAdminResponseDto } from '@immich/sdk';
-  import { Button, HStack, IconButton, Link, Text } from '@immich/ui';
-  import { mdiDeleteRestore, mdiInfinity, mdiPencilOutline, mdiPlusBoxOutline, mdiTrashCanOutline } from '@mdi/js';
+  import { Button, HStack, IconButton, Text } from '@immich/ui';
+  import { mdiDeleteRestore, mdiEyeOutline, mdiInfinity, mdiPlusBoxOutline, mdiTrashCanOutline } from '@mdi/js';
   import { DateTime } from 'luxon';
   import { onMount } from 'svelte';
   import { t } from 'svelte-i18n';
@@ -63,13 +62,6 @@
     await refresh();
   };
 
-  const handleEdit = async (dto: UserAdminResponseDto) => {
-    const result = await modalManager.show(UserEditModal, { user: dto });
-    if (result) {
-      await refresh();
-    }
-  };
-
   const handleDelete = async (user: UserAdminResponseDto) => {
     const result = await modalManager.show(UserDeleteConfirmModal, { user });
     if (result) {
@@ -116,9 +108,9 @@
                   ? 'bg-red-300 dark:bg-red-900'
                   : 'even:bg-subtle/20 odd:bg-subtle/80'}"
               >
-                <td class="w-8/12 sm:w-5/12 lg:w-6/12 xl:w-4/12 2xl:w-5/12 text-ellipsis break-all px-2 text-sm"
-                  ><Link href="{AppRoute.ADMIN_USERS}/{immichUser.id}">{immichUser.email}</Link></td
-                >
+                <td class="w-8/12 sm:w-5/12 lg:w-6/12 xl:w-4/12 2xl:w-5/12 text-ellipsis break-all px-2 text-sm">
+                  {immichUser.email}
+                </td>
                 <td class="hidden sm:block w-3/12 text-ellipsis break-all px-2 text-sm">{immichUser.name}</td>
                 <td class="hidden xl:block w-3/12 2xl:w-2/12 text-ellipsis break-all px-2 text-sm">
                   <div class="container mx-auto flex flex-wrap justify-center">
@@ -136,10 +128,10 @@
                     <IconButton
                       shape="round"
                       size="medium"
-                      icon={mdiPencilOutline}
-                      title={$t('edit_user')}
-                      onclick={() => handleEdit(immichUser)}
-                      aria-label={$t('edit_user')}
+                      icon={mdiEyeOutline}
+                      title={$t('view_user')}
+                      href={`${AppRoute.ADMIN_USERS}/${immichUser.id}`}
+                      aria-label={$t('view_user')}
                     />
                     {#if immichUser.id !== $user.id}
                       <IconButton